Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate errors raised when loading the webpack configuration file #2627

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: closes #2421

What is the new behavior?

propagate any errors raised when loading the webpack configuration file. For example:

1. when webpack config path is not supplied but the file do exists

in this case I didn't installed run-script-webpack-plugin and the config file is using it

image

2. when the supplied webpack config path is not found

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No(?)

@kamilmysliwiec kamilmysliwiec merged commit 952da4b into nestjs:master Jul 5, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in default webpack config file (webpack.config.json) are silently ignored
2 participants