feat: allow for custom logger with streamable files #12558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When the StreamableFile handle has an error, it uses the built in
this.logger.error()
handler to log the error. This works, but can cause a lot of noise with the stack trace that gets printed.Issue Number: #12542
What is the new behavior?
Devs are now able to do
new StreamableFile().setErrorLogger((err) => this.logger.error(err.message))
to only log the message and not the stack trace, or whatever other custom logging they want to useDoes this PR introduce a breaking change?
Other information