feat(common): modify Logger to allow setting a prefix #13913
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #13841
What is the new behavior?
Hello,
I became interested in this issue, so I made some methods.
As suggested in the issue (
app.setLoggerPrefix('my-app-name')
), I created a setLoggerPrefix method.I expected it to be used in this way.
However, I noticed that logging also occurs when
NestFactory.create
is called. The prefix set withapp.setLoggerPrefix
does not apply to these log messages becauseNestFactory.create
is called beforeapp.setLoggerPrefix
.To address this, I added a
loggerPrefix
field toNestApplicationContextOptions
, and now you can use it like this:What are your thoughts on this approach? I'd appreciate your feedback.
Does this PR introduce a breaking change?
Other information