Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #5093 #5098

Merged
merged 3 commits into from
Jul 17, 2020
Merged

fix #5093 #5098

merged 3 commits into from
Jul 17, 2020

Conversation

wayou
Copy link
Contributor

@wayou wayou commented Jul 16, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5093

What is the new behavior?

Correct the type of ClientProviderOptions.name to accept Symbol

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

coveralls commented Jul 16, 2020

Pull Request Test Coverage Report for Build 6908bf10-9d4e-4b03-977e-7653779ab2d2

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.817%

Totals Coverage Status
Change from base Build 0934aae2-2490-4c65-9fda-1dd74b49a5e6: 0.0%
Covered Lines: 4921
Relevant Lines: 5190

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec merged commit b39cf9f into nestjs:master Jul 17, 2020
@kamilmysliwiec
Copy link
Member

kamilmysliwiec commented Jul 17, 2020

Thanks! It will be published as part of the next patch release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants