-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform-fastify): adds missing chaining API types for LightMyRequest inject() #5628
Merged
kamilmysliwiec
merged 2 commits into
nestjs:master
from
squareloop1:fix/add-missing-chaining-api
Nov 2, 2020
Merged
fix(platform-fastify): adds missing chaining API types for LightMyRequest inject() #5628
kamilmysliwiec
merged 2 commits into
nestjs:master
from
squareloop1:fix/add-missing-chaining-api
Nov 2, 2020
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build d391710a-b735-4cea-8768-6147c05fcad8
💛 - Coveralls |
Thanks! |
This was referenced Mar 15, 2021
This was referenced May 23, 2021
Closed
This was referenced May 31, 2021
Open
Open
This was referenced Jun 6, 2021
1 task
This was referenced Jul 7, 2021
Closed
This was referenced Aug 8, 2021
leeklife
pushed a commit
to leeklife/nest
that referenced
this pull request
Jan 20, 2022
BREAKING CHANGE: Angular updated to version 9. Nebular updated to version 5. `@agm/core` replaced with `@angular/google-maps`. `ng2-completer` replaced with `@akveo/ng2-completer`, read details [here](akveo/ng2-smart-table#1140 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If we currently use inject() from LightMyRequest to test the application we need to call it like this:
If we try to use the chaining API we are getting TypeScript errors like
TS2554: Expected 1 arguments, but got 0.
because of missing types.What is the new behavior?
With the chaining API (https://github.com/fastify/light-my-request#method-chaining) we can also call it in a fluent style like this:
Types for this were missing, this PR adds the missing types to be able to use the chaining API. It also allows a usage which is more in line with other testing libraries like e.g. supertest.
Does this PR introduce a breaking change?
Other information