Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microservices): Add BrokersFunction to KafkaConfig brokers property #5634

Merged
merged 1 commit into from
Nov 2, 2020
Merged

feat(microservices): Add BrokersFunction to KafkaConfig brokers property #5634

merged 1 commit into from
Nov 2, 2020

Conversation

smhmayboudi
Copy link
Contributor

@smhmayboudi smhmayboudi commented Oct 30, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5633

What is the new behavior?

You can add a function to set brokers.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 31671

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 160 unchanged lines in 31 files lost coverage.
  • Overall coverage increased (+0.7%) to 95.443%

Files with Coverage Reduction New Missed Lines %
packages/common/decorators/http/route-params.decorator.ts 1 88.1%
packages/common/pipes/validation.pipe.ts 1 94.38%
packages/core/router/router-execution-context.ts 1 97.42%
packages/microservices/client/client-redis.ts 1 92.86%
packages/microservices/server/server-kafka.ts 1 97.54%
packages/microservices/server/server-mqtt.ts 1 96.83%
packages/websockets/socket-server-provider.ts 1 91.18%
packages/common/decorators/core/apply-decorators.ts 2 66.67%
packages/common/decorators/core/set-metadata.decorator.ts 2 85.71%
packages/microservices/client/client-kafka.ts 2 97.12%
Totals Coverage Status
Change from base Build 31dcaa7c-d83e-4300-bead-bda09e984628: 0.7%
Covered Lines: 4482
Relevant Lines: 4696

💛 - Coveralls

@galesky
Copy link
Contributor

galesky commented Oct 31, 2020

Hello @smhmayboudi,

I think you referenced the wrong issue, isn't #5633 ?

@smhmayboudi
Copy link
Contributor Author

Hello @galesky, Yes you are right. I fixed the PR.

@kamilmysliwiec kamilmysliwiec added this to the 7.5.0 milestone Nov 2, 2020
@kamilmysliwiec kamilmysliwiec merged commit b8c6373 into nestjs:master Nov 2, 2020
@smhmayboudi smhmayboudi deleted the 5629-feat-KafkaConfig-brokers branch November 2, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants