Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose FILE_UPLOAD_MAX_MEMORY_SIZE as a setting in core netbox #11592

Closed
dmulyalin opened this issue Jan 26, 2023 · 2 comments · Fixed by #11742
Closed

Expose FILE_UPLOAD_MAX_MEMORY_SIZE as a setting in core netbox #11592

dmulyalin opened this issue Jan 26, 2023 · 2 comments · Fixed by #11742
Assignees
@aronbergurj99
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@dmulyalin
Copy link

NetBox version

v3.3.9

Feature type

New functionality

Proposed functionality

Raised this issue to investigate it and was advised that FILE_UPLOAD_MAX_MEMORY_SIZE setting is not configurable, hence need to raise a request to add it to core Netbox functionality.

Use case

To be able to upload files bigger than 2.5Mbyte to custom scripts for processing.

Database changes

Nill

External dependencies

Nill
@dmulyalin dmulyalin added the type: feature Introduction of new functionality to the application label Jan 26, 2023
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Jan 26, 2023
@aronbergurj99
Copy link
Contributor

I volunteer to own this.

aronbergurj99 pushed a commit to aronbergurj99/netbox that referenced this issue Jan 26, 2023
Closes netbox-community#11592: Expose FILE_UPLOAD_MAX_MEMOMORY_SIZE a…
38611a3 
…s a setting
@jeremystretch
Copy link
Member

Sorry @aronbj20, I missed this earlier. All yours!

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Feb 12, 2023
@aronbergurj99 aronbergurj99 mentioned this issue Feb 13, 2023
Merged
jeremystretch pushed a commit that referenced this issue Feb 16, 2023
@aronbergurj99 @aronminn
Closes #11592: Expose FILE_UPLOAD_MAX_MEMORY_SIZE as a setting (#11742)
2db181e 
* Closes #11592: Expose FILE_UPLOAD_MAX_MEMOMORY_SIZE as a setting

* change configuration settings to alphabetic order

* Small example and documentation

---------

Co-authored-by: aron bergur jóhannsson <[email protected]>
jeremystretch added a commit that referenced this issue Feb 17, 2023
@jeremystretch
Changelog for #11226, #11335, #11473, #11592
3a4fee4
@jeremystretch jeremystretch mentioned this issue Feb 21, 2023
Merged
@jvoss jvoss mentioned this issue Feb 21, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aronbergurj99 aronbergurj99

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #11592: Expose FILE_UPLOAD_MAX_MEMORY_SIZE as a setting aronbergurj99/netbox
3 participants
@jeremystretch @dmulyalin @aronbergurj99