Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface types: 100gbase-x-dsfp and 100gbase-x-sfpdd #13234

Closed
danner26 opened this issue Jul 21, 2023 · 2 comments · Fixed by #13236
Closed

Add interface types: 100gbase-x-dsfp and 100gbase-x-sfpdd #13234

danner26 opened this issue Jul 21, 2023 · 2 comments · Fixed by #13236
Assignees
@danner26
Labels
type: feature Introduction of new functionality to the application

Comments

@danner26
Copy link
Member

danner26 commented Jul 21, 2023 •
edited
Loading

NetBox version

v3.5.6

Feature type

Data model extension

Proposed functionality

100gbase-x-dsfp and 100gbase-x-sfpdd are legitament interfaces

Use case

These are being requested for use in the community downstream repo: DeviceType-Library PR#1477

Database changes

No response

External dependencies

No response
@danner26 danner26 added the type: feature Introduction of new functionality to the application label Jul 21, 2023
@danner26 danner26 self-assigned this Jul 21, 2023
@danner26 danner26 mentioned this issue Jul 21, 2023
Closed
@danner26
Copy link
Member Author

Actually, are the 100gbase-x-sfpdd actually 100gbase-x-qsfpdd?

@danner26 danner26 changed the title Add interface types: 100gbase-x-sfpdd & 100gbase-x-dsfp Add interface types: 100gbase-x-dsfp Jul 21, 2023
@danner26 danner26 mentioned this issue Jul 21, 2023
Merged
@danner26 danner26 changed the title Add interface types: 100gbase-x-dsfp Add interface types: 100gbase-x-dsfp and 100gbase-x-qsfpdd Jul 25, 2023
@danner26 danner26 changed the title Add interface types: 100gbase-x-dsfp and 100gbase-x-qsfpdd Add interface types: 100gbase-x-dsfp and 100gbase-x-sfpdd Jul 25, 2023
@danner26
Copy link
Member Author

100gbase-x-sfpdd is its own type. Added to the PR

@danner26 danner26 assigned danner26 and unassigned danner26 Jul 25, 2023
jeremystretch added a commit that referenced this issue Jul 28, 2023
@jeremystretch
Changelog for #11803, #13009, #13234, #13285
d9dc6ce
@jeremystretch jeremystretch mentioned this issue Jul 28, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danner26 danner26

Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding 100gbase-x-dsfp and 100gbase-x-sfpdd danner26/netbox
1 participant
@danner26