Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for base choices only in CustomFieldChoices #13361

Closed
rodvand opened this issue Aug 3, 2023 · 1 comment
Closed

Allow for base choices only in CustomFieldChoices #13361

rodvand opened this issue Aug 3, 2023 · 1 comment
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@rodvand
Copy link
Contributor

rodvand commented Aug 3, 2023

NetBox version

v3.6-beta1

Feature type

Change to existing functionality

Proposed functionality

Remove the required flag on the Extra Choices field on Custom Field Choices.

Use case

If I want a custom field with only the airport codes, I don't want to add any extra choices. I would like to select the Base Choices and leave it at that. Currently I am forced to add an extra choice to be able to use the base choices.

Database changes

I assume it means the extra choices field must be set to not required. It will however need extra validation to make sure you either choose a set of base choices or add some extra choices.

External dependencies

No response
@rodvand rodvand added the type: feature Introduction of new functionality to the application label Aug 3, 2023
@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation beta Concerns a bug/feature in a beta release and removed type: feature Introduction of new functionality to the application labels Aug 3, 2023
@jeremystretch
Copy link
Member

This field is meant to be optional (and is on the model itself). Looks like a bug with the form.

jeremystretch added a commit that referenced this issue Aug 3, 2023
@jeremystretch
Fixes #13361: Extra choices field on custom field choice set form sho…
d9f3637 
…uld not be required
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rodvand @jeremystretch