Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include actions menu on all object tables #7679

Closed
rhyser9 opened this issue Oct 28, 2021 · 3 comments
Closed

Include actions menu on all object tables #7679

rhyser9 opened this issue Oct 28, 2021 · 3 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@rhyser9
Copy link
Contributor

rhyser9 commented Oct 28, 2021

NetBox version

v3.0.9-dev

Feature type

New functionality

Proposed functionality

The Locations, Site Groups, and Regions tables have action buttons to edit, delete, and view changelog for each record. This request is to add the actions column to the Sites table as well.

image

Use case

This would make the sites table more consistent with it's related tables, as well as potentially facilitate adding a site elevations button as I mentioned in #7668.

Database changes

No response

External dependencies

No response

@rhyser9 rhyser9 added the type: feature Introduction of new functionality to the application label Oct 28, 2021
@jeremystretch
Copy link
Member

"Action" buttons are included in the tables only for organizational models. This was done originally because these models did not have dedicated views where these links would normally be found. Any proposal to add similar buttons to other models would need to include all other models for consistency.

This is probably doable, especially now that table columns are configurable, but I'm not sure the development effort and overhead are worthwhile.

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Oct 29, 2021
@jeremystretch
Copy link
Member

It probably makes sense to condense most of these buttons into a dropdown menu, and to make that menu available on all object tables, similar to what @PieterL75 proposes in #7953.

@jeremystretch jeremystretch changed the title Add action button column to sites table Include actions menu on all object tables Dec 13, 2021
@jeremystretch jeremystretch added needs milestone Awaiting prioritization for inclusion with a future NetBox release status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation needs milestone Awaiting prioritization for inclusion with a future NetBox release labels Dec 13, 2021
@jeremystretch jeremystretch added this to the v3.2 milestone Dec 15, 2021
@jeremystretch jeremystretch self-assigned this Jan 6, 2022
jeremystretch added a commit that referenced this issue Jan 10, 2022
jeremystretch added a commit that referenced this issue Jan 10, 2022
jeremystretch added a commit that referenced this issue Jan 10, 2022
@jeremystretch
Copy link
Member

Added a dropdown with edit/delete/changelog links for all objects:

Screenshot 2022-01-10 at 11-39-03 Sites NetBox

This was referenced Apr 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants