Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow images to be attached to Modules and Module Types #8846

Closed
jcollie opened this issue Mar 10, 2022 · 4 comments
Closed

Allow images to be attached to Modules and Module Types #8846

jcollie opened this issue Mar 10, 2022 · 4 comments
Assignees
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@jcollie
Copy link

jcollie commented Mar 10, 2022

NetBox version

netbox-9959f6cd8-pzbbx (v3.2.0-beta2)

Feature type

New functionality

Proposed functionality

Allow images to be attached to modules and module types.

Use case

Having images of modules will help users identify modules.

Database changes

Lists of images will need to be added to modules and module types.

External dependencies

No response

@jcollie jcollie added the type: feature Introduction of new functionality to the application label Mar 10, 2022
@jeremystretch
Copy link
Member

I think module types makes sense, but why modules?

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Mar 14, 2022
@jcollie
Copy link
Author

jcollie commented Mar 14, 2022

Allowing on module is mostly for completeness I guess, based on device type/device. It would be good for documenting the installation of a specific module (maybe there are switches on the module that need to be configured in a certain way). It also just occurred to me that it would be good to be able to attach images to device types other than the front/rear images. That would be good for devices that aren't really rack mountable or for attaching documentation about a device type.

@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Mar 14, 2022
@jeremystretch
Copy link
Member

Wouldn't it make more sense to attach any images to the parent device, rather than to a specific module?

@jcollie
Copy link
Author

jcollie commented Mar 21, 2022

For an installed module images from the parent device would be OK. However, it would still be nice to attach an image to the module type so that you can say "this is what X looks like" without having to do a web search for it (which can sometimes fail or be ambiguous, depending on the obscurity of the particular module).

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Mar 23, 2022
@jeremystretch jeremystretch self-assigned this Mar 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants