Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weight to device type / device #9654

Closed
powerscooter opened this issue Jul 3, 2022 · 5 comments
Closed

Add weight to device type / device #9654

powerscooter opened this issue Jul 3, 2022 · 5 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@powerscooter
Copy link

NetBox version

v3.2.3

Feature type

New functionality

Proposed functionality

Hi,

would it be possible to add a weight field (kg) to the Device Type and Device?

Use case

We can only fit a certain weight per rack, we would like to document this directly in Netbox.
For this it would be nice to have this at the Device Type, Device and afterwards as a view at the Rack.

Database changes

No response

External dependencies

No response

@powerscooter powerscooter added the type: feature Introduction of new functionality to the application label Jul 3, 2022
@jeremystretch
Copy link
Member

If we add this, we should take the same approach that we do for storing cable length: Allow the user to specify both a value and a unit (e.g. kilograms or pounds), but also store the absolute weight in kilograms for ordering and filtering. This is because manufacturers may list a device's weight in only one unit or the other, and avoids requiring users to do conversions before entering the data into NetBox.

@jeremystretch jeremystretch added the needs milestone Awaiting prioritization for inclusion with a future NetBox release label Jul 5, 2022
@powerscooter
Copy link
Author

Yes that sounds good. That's exactly how it would be perfect.

@brainsfull
Copy link

brainsfull commented Jul 17, 2022

We often have floor loading limitations where this feature would be very useful. Suggest weight is also added to the module type which adds to the total device weight. For larger chassis based equipment this will provide a more accurate weight per rack/cabinet. It also would be useful to track rack max. weight capacity (either a factor of the total rack make/model capacity or the floor's loading capacity) so the viewer can see the available weight capacity of the cabinet in a bar chart like you currently can with circuit power.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed needs milestone Awaiting prioritization for inclusion with a future NetBox release labels Jul 27, 2022
@jeremystretch jeremystretch added this to the v3.4 milestone Jul 27, 2022
@jeremystretch
Copy link
Member

Suggest weight is also added to the module type which adds to the total device weight. For larger chassis based equipment this will provide a more accurate weight per rack/cabinet.

I think if we take this approach we should add weight fields only to the DeviceType and ModuleType models, and introduce a read-only weight property on device which reports the sum of the device type's weight and the weight of all modules.

@DanSheps
Copy link
Member

My only concern is, if we are talking about floor load limits, a rack also adds to the overall weight.

Might it be better to have a weight field, with a weighs property to return the sum of any components.

This would allow you to have both a weight and a weighs on a rack, where weighs would return the sum of all devices weighs "property".

@arthanson arthanson self-assigned this Sep 22, 2022
jeremystretch added a commit that referenced this issue Sep 30, 2022
jeremystretch added a commit that referenced this issue Nov 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

5 participants