Fixes #17301: Fix script module edit & delete button styling #17328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
requested changes
Aug 30, 2024
There was a problem hiding this comment.
The button text is black in light mode, this is in contrast to the other buttons and what prompted the latest changes. It picks up the styling from h2, which is why I had moved it out of the h2. Also IMHO the buttons aren't very noticeable and I don't know we use any buttons like that anywhere else?
|
It looks colored correctly for me:
We use these transparent background ("ghost") buttons on panels elsewhere pretty consistently. Image attachments, for instance:
|
ah, sorry - had to clear cache. |
arthanson
approved these changes
Aug 30, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17301
<h2>card headers