5.0.0 Release #256
Merged
5.0.0 Release #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes netsted objects behave just as if they were accessed directly
Fixes #241: Inconsistent hashing for nested api objects
Fix endpoint hash
Make get_openapi method on Request and exposes it via openapi method on Api.
Add openapi query
In order to set a custom http_session for use universally we need to move any requests out of Api's init. Moving it to App and only calling it when we need App.secrets.
Move population of api.session_key to App
Make get() return None if we passed an incorrect id.
Fixes #224 - Catch RequestError in .get()
With the ability to set api.http_session to a custom Session we can handle SSL verification with it instead of an explicit kwarg.
Remove ssl_verify init kwarg
Make DetailEndpoint.create() return objects when custom_return is not empty.
Record return custom
added 5 commits
June 24, 2020 21:22
Use Black and Pytest in GH Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Api.openapi()method that returns a dictionary of the entire OpenAPI spec.Breaking Changes
Api.http_sessionto be overridden by user-supplied customrequests.Session()objects to more precisely control certain requests behavior. While this was possible before, it wasn't applied to all requests. For example, getting session keys was done inApi().__init__()which wouldn't respect a custom http_session. This behavior has been changed and will now only occur when the secrets endpoint is called.Note: this change removes the
ssl_verifykwarg passed to.api()that controlled certificate validation in previous versions. Please see the docs for the new method.Endpoint.get()andEndpoint.filter()behave similarly (return None) when the resource isn't found..create()on detail endpoint routes likeavailable-ipsandavailable-prefixes.