Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency dot-prop to v6 #3006

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 14, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
dot-prop ^5.3.0 -> ^6.0.0 age adoption passing confidence

Release Notes

sindresorhus/dot-prop

v6.0.1

Compare Source

  • Fix default value issue when last part of part of path is undefined (#​75) dcc7f73

v6.0.0

Compare Source

Breaking

Configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner June 14, 2021 01:44
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jun 14, 2021
@renovate renovate bot force-pushed the renovate/dot-prop-6.x branch 2 times, most recently from f207c43 to db4947d Compare June 14, 2021 05:32
@renovate renovate bot deleted the renovate/dot-prop-6.x branch June 14, 2021 12:08
@renovate
Copy link
Contributor Author

renovate bot commented Aug 12, 2021

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 6.x releases. However, if you upgrade to 6.x manually then Renovate will reenable minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@XhmikosR
Copy link
Contributor

@erezrokah just wondering, why did you choose to ignore v6? It's not ESM only. Does it cause other issues?

I'm asking because it seems your are using v6 in CLI:

C:\Users\XhmikosR\Desktop\cli>npm ls dot-prop
[email protected] C:\Users\XhmikosR\Desktop\cli
+-- @netlify/[email protected]
| `-- [email protected]
+-- @netlify/[email protected]
| `-- @commitlint/[email protected]
|   `-- [email protected]
|     `-- [email protected]
|       `-- [email protected]
+-- [email protected]
| `-- [email protected]
+-- [email protected]
`-- [email protected]
  `-- [email protected]

Judging by the number of packages that depend on v5, it could probably stay on v6. This isn't too important for just 1 package, but it counts on a big project like CLI. There are plenty of other cases too. I think that some if not most of just duplicate deps issues will be fixed with ESM, but still it's easy to pull the trigger on an package that introduces tens of packages.

Just my 2 cents after all this time looking into the number of packages for CLI :)

@erezrokah
Copy link
Contributor

To be honest. Do really remember, maybe we still supported Node.js 10 back then.

I triggered it to run again via #1653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants