-
Notifications
You must be signed in to change notification settings - Fork 352
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: fix TypeScript errors in login and logout files (#6880)
* chore: fix TypeScript errors in login and logout files Fixed TS errors in login and logout. Created `tokenTuple` type for the `getToken` function's return type Updated `getToken` function calls to remove TypeScript ignore comments Co-authored-by: Ben Hancock<[email protected]> * fix: corrected tuple type Co-authored-by: Ben Hancock <[email protected]> * fix: type narrowed in /integration/deploy.ts to avoid passing undefined tokens Co-authored-by: Ben Hancock <[email protected]> * chore: extracted Location to its own type Co-authored-by: Ben Hancock <[email protected]> * fix: fix to building headers object for fetch request in deploy.ts Co-authored-by: Ben Hancock <[email protected]> * fix: reverted `getToken` changes back to previous In cases where `getToken` can't find a token, changed it back to previous behavior of returning `[null, 'not found']`. Changed `tokenTuple` type to reflect changes. This preserves previous behavior while ensuring type safety for function calls that use `getToken`'s return value. This required a new variable `blobsToken` to satisfy `runCoreSteps` function argument type requirements. Co-authored-by: Ben Hancock <[email protected]> * Update src/utils/types.ts Co-authored-by: Daniel Lew <[email protected]> * fix: updated Location type to TokenLocation to be more specific Co-authored-by: Ben Hancock <[email protected]> --------- Co-authored-by: Ben Hancock <[email protected]> Co-authored-by: Daniel Lew <[email protected]>
- Loading branch information
1 parent
e9623e6
commit 08ce662
Showing
8 changed files
with
23 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters