feat: check for deno vs code ext and download when prompted (#4698)

* fix: check for deno vs code ext and download when prompted * fix: change execSync to use execa * fix: change execSync to use execa * fix: catch error during extension install to fix tests or if vscode not installed * fix: add error catching * fix: bypass prompt when error checking for deno * fix: move error handling to single block * fix: add stderr piping to execa command * fix: add stderr piping to execa commands * fix: dot diff in test * Update src/recipes/vscode/index.js Co-authored-by: Eduardo Bouças <[email protected]> * chore: revert snapshot change Co-authored-by: Eduardo Bouças <[email protected]>
netlify · Jun 21, 2022 · b09b86e · b09b86e · github-actions · Jun 21, 2022
1 parent a67ec05
commit b09b86e
Showing 1 changed file with 33 additions and 4 deletions.
diff --git a/src/recipes/vscode/index.js b/src/recipes/vscode/index.js
@@ -1,5 +1,6 @@
 const { join } = require('path')
 
+const execa = require('execa')
 const inquirer = require('inquirer')
 
 const { NETLIFYDEVLOG, NETLIFYDEVWARN, chalk, error, log } = require('../../utils/command-helpers')
@@ -27,6 +28,26 @@ const getEdgeFunctionsPath = ({ config, repositoryRoot }) =>
 
 const getSettingsPath = (repositoryRoot) => join(repositoryRoot, '.vscode', 'settings.json')
 
+const hasDenoVSCodeExt = async () => {
+  const { stdout: extensions } = await execa('code', ['--list-extensions'], { stderr: 'inherit' })
+  return extensions.split('\n').includes('denoland.vscode-deno')
+}
+
+const getDenoVSCodeExt = async () => {
+  await execa('code', ['--install-extension', 'denoland.vscode-deno'], { stdio: 'inherit' })
+}
+
+const getDenoExtPrompt = () => {
+  const message = 'The Deno VS Code extension is recommended. Would you like to install it now?'
+
+  return inquirer.prompt({
+    type: 'confirm',
+    name: 'confirm',
+    message,
+    default: true,
+  })
+}
+
 const run = async ({ config, repositoryRoot }) => {
   const { DenoBridge } = await import('@netlify/edge-bundler')
   const deno = new DenoBridge({
@@ -45,14 +66,22 @@ const run = async ({ config, repositoryRoot }) => {
   }
 
   try {
-    await writeSettings({ settings, settingsPath })
-
-    log(`${NETLIFYDEVLOG} VS Code settings file ${fileExists ? 'updated' : 'created'}.`)
+    if (!(await hasDenoVSCodeExt())) {
+      const { confirm: denoExtConfirm } = await getDenoExtPrompt()
+      if (denoExtConfirm) getDenoVSCodeExt()
+    }
+  } catch {
     log(
-      `${NETLIFYDEVWARN} If you don't have the Deno VS Code extension, install it by visiting ${chalk.blue(
+      `${NETLIFYDEVWARN} Unable to install Deno VS Code extension. To install it manually, visit ${chalk.blue(
         'https://ntl.fyi/deno-vscode',
       )}.`,
     )
+  }
+
+  try {
+    await writeSettings({ settings, settingsPath })
+
+    log(`${NETLIFYDEVLOG} VS Code settings file ${fileExists ? 'updated' : 'created'}.`)
   } catch {
     error('Could not write VS Code settings file.')
   }