Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show progress while waiting for framework server to start #3288

Closed
erezrokah opened this issue Sep 2, 2021 · 0 comments · Fixed by #4683
Closed

feat: show progress while waiting for framework server to start #3288

erezrokah opened this issue Sep 2, 2021 · 0 comments · Fixed by #4683
Assignees
Labels
area: command: dev area: dx area: frameworks good first issue type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@erezrokah
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Related to #3242 (comment)

When we start a framework server (e.g. Gatsby) we try to connect to the default port of that framework.
However, if a user configures a custom port they should tell netlify dev about it.

The problem is that netlify dev times out after 10 minutes and does't show any kind of progress while waiting for the framework server to start, so the user thinks the CLI is stuck and has not way of knowing what the problem is.

Most users won't wait 10 minutes for the CLI to timeout.

Describe the solution you'd like

The CLI should show some kind of progress while waiting to the framework server to start, detailing the port its trying to connect to and how to configure it.

This is a bit tricky since CLI logs are interleaved with the framework process logs

Describe alternatives you've considered

Possibly detecting the configured port, but that's a bigger lift

Additional context

#3242 (comment)

Can you submit a pull request?

Yes

@erezrokah erezrokah added type: feature code contributing to the implementation of a feature and/or user facing functionality area: command: dev good first issue area: dx area: frameworks labels Sep 2, 2021
@ericapisani ericapisani self-assigned this Jun 8, 2022
@kodiakhq kodiakhq bot closed this as completed in #4683 Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: command: dev area: dx area: frameworks good first issue type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants