-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show progress while waiting for framework server to start #4683
feat: show progress while waiting for framework server to start #4683
Conversation
📊 Benchmark resultsPackage size: 294 MB
Legend
|
…' of github.com:netlify/cli into ep/show-progress-while-waiting-for-framework-to-startup
…' of github.com:netlify/cli into ep/show-progress-while-waiting-for-framework-to-startup
the regex being applied was affecting other tests
…' of github.com:netlify/cli into ep/show-progress-while-waiting-for-framework-to-startup
…' of github.com:netlify/cli into ep/show-progress-while-waiting-for-framework-to-startup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and works great!
CleanShot.2022-06-10.at.15.54.18.mp4
We have some random test failures now, that sometimes contain a https://github.com/netlify/cli/runs/6925957490?check_suite_focus=true Can you have a look at why this is happening? |
@danez, @ericapisani is currently on PTO for the next little while. I know she had put something in place to make the snapshot tests consistent with the dots. How big a blocker is it at the moment? Is it occasional or pretty frequent the failures? |
Ah okay, then i will see if i can figure something out maybe. It is not super urgent, nothing that can't wait a little. |
Summary
Fixes #3288
From the issue linked above:
Before video
https://user-images.githubusercontent.com/5655473/172719545-9a84bc50-1ffd-474a-8723-d947b1ba46e3.mov
After video
https://user-images.githubusercontent.com/5655473/172719578-6f06de6a-a45d-4f7b-9ddf-83478b139ddb.mov
Related documentation/notes
wait-port
package are only 'dots' or 'silent', related code can be found heretargetPort
we were waiting for based on thenetlify dev
docsFor us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)