Improve robustness of netlify-lambda function-builder-detector #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes netlify#1726 and will find the functions folder regardless if, and where, any arguments are passed to the 'netlify-lambda build' command
erezrokah
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
Thanks for the fix @Robin-Hoodie. This looks good and sorry for the delay reviewing it
| break | ||
| if (script.match(/netlify-lambda\s+build/)) { | ||
| // E.g. ["netlify-lambda", "build", "functions/folder"] | ||
| const match = minimist(script.split(' ')) |
There was a problem hiding this comment.
This isn't whitespace safe (e.g. a functions folder with a whitespace will break this), but the current approach isn't either and this works for more use cases.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
This PR fixes a few edge cases where the
netlify-lambda buildcommand would be detected, but would not run correctlynelify-lambdacommands (though this was already working, this was not tested)- Test plan
You can view the added tests in the commits
- Description for the changelog
Improve detection of invalid
netlify-lambda buildcommands & detect functions folder regardless of options placement- A picture of a cute animal (not mandatory but encouraged)
My 2 cats when they were kittens: