test(command-lm): add uninstall command #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
erezrokah
changed the title
ehmicky
reviewed
Feb 15, 2021
| const getGitConfigContent = (gitConfigPath) => ` | ||
| # This next lines include Netlify's Git Credential Helper configuration in your Git configuration. | ||
| [include] | ||
| path = ${path.posix.normalize(gitConfigPath)} |
There was a problem hiding this comment.
This might not work as expected.
path.posix.normalize() actually returns backslashes on Windows (which is confusing).
Is the intent to only use forward slashes? If so, I have personally used this unmaintained package: https://github.com/jonschlinkert/unixify (we use it in zip-it-and-ship-it). If you find a better package, I'd be curious to learn about it too :)
Edit: I am realizing this change was not introduced by the current PR, so please feel free to ignore for this PR.
ehmicky
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1489.
Adds a hidden command to undo the changes made by
ntl lm:install(to be used by our tests).