feat: deprecate netlify:edge in function templates
#4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
📊 Benchmark resultsComparing with 0eb9d16 Package size: 222 MB⬇️ 0.00% decrease vs. 0eb9d16 Legend
|
danez
reviewed
Jul 22, 2022
| @@ -1,4 +1,4 @@ | |||
| import { Context } from "netlify:edge"; | |||
| import { Context } from "https://edge.netlify.com"; | |||
There was a problem hiding this comment.
Suggested change
| import { Context } from "https://edge.netlify.com"; | |
| import type { Context } from "https://edge.netlify.com"; |
| @@ -1,4 +1,4 @@ | |||
| import { Context } from "netlify:edge"; | |||
| import { Context } from "https://edge.netlify.com"; | |||
There was a problem hiding this comment.
Suggested change
| import { Context } from "https://edge.netlify.com"; | |
| import type { Context } from "https://edge.netlify.com"; |
I'd rather do that separately, if you don't mind. These templates come mostly from https://edge-functions-examples.netlify.app/, so if there's something in them we want to change, we should update stream as well. Let's do a more holistic review of these templates as a separate initiative. |
danez
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
netlify:edgewithhttps://edge.netlify.comin Edge Functions templates.Part of https://github.com/netlify/pillar-runtime/issues/322.