-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent promptEditorHelper to run if running tests in vscode #4863
Merged
khendrikse
merged 3 commits into
main
from
fix/4862/prevent-prompt-editor-helper-in-vscode-tests
Jul 26, 2022
Merged
fix: prevent promptEditorHelper to run if running tests in vscode #4863
khendrikse
merged 3 commits into
main
from
fix/4862/prevent-prompt-editor-helper-in-vscode-tests
Jul 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 1d63b08 Package size: 221 MB(no change)
Legend
|
eduardoboucas
previously approved these changes
Jul 26, 2022
Co-authored-by: Eduardo Bouças <[email protected]>
danez
previously approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for looking into this.
danez
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
khendrikse
deleted the
fix/4862/prevent-prompt-editor-helper-in-vscode-tests
branch
July 26, 2022 11:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4862
Added a check for test environment inside the
promptEditorHelper
function. This decision was made based upon the thought that we could either change theenv.TERM_PROGRAM
in all tests, or check if theenv.NODE_ENV
wastest
.For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)