-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graph): open-ended codegen #4896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrove
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Aug 3, 2022
📊 Benchmark resultsComparing with f02d08e Package size: 228 MB⬆️ 0.07% increase vs. f02d08e
Legend
|
sgrove
changed the title
feat (graph): open-ended codegen
feat(graph): open-ended codegen
Aug 8, 2022
anmonteiro
reviewed
Aug 8, 2022
anmonteiro
reviewed
Aug 8, 2022
anmonteiro
reviewed
Aug 8, 2022
anmonteiro
reviewed
Aug 8, 2022
anmonteiro
reviewed
Aug 8, 2022
anmonteiro
reviewed
Aug 8, 2022
anmonteiro
reviewed
Aug 8, 2022
anmonteiro
reviewed
Aug 8, 2022
anmonteiro
reviewed
Aug 8, 2022
// ensureNetlifyGraphPath(netlifyGraphConfig) | ||
runtime.forEach((file) => { | ||
const implementationResolvedPath = path.resolve(...file.name) | ||
fs.writeFileSync(implementationResolvedPath, file.content, 'utf8') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not to fix: we should probably start using 'fs/promises'
instead
anmonteiro
reviewed
Aug 8, 2022
anmonteiro
reviewed
Aug 8, 2022
anmonteiro
previously approved these changes
Aug 8, 2022
anmonteiro
previously approved these changes
Aug 8, 2022
anmonteiro
previously approved these changes
Aug 8, 2022
anmonteiro
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Add to Kodiak auto merge queue
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Brings in fixes for e.g. nested fragments and some Graph lockfile merging, but mainly focuses on getting the open-ended Graph codegen and typed CLI session events so that the UI and CLI communicate properly.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.