-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show displayName for any edge function that has one being run with netlify dev #5487
Merged
khendrikse
merged 3 commits into
main
from
feat-373/show-display-name-for-edge-functions-when-running-ntl-dev
Feb 20, 2023
Merged
feat: show displayName for any edge function that has one being run with netlify dev #5487
khendrikse
merged 3 commits into
main
from
feat-373/show-display-name-for-edge-functions-when-running-ntl-dev
Feb 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khendrikse
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Feb 17, 2023
…s-when-running-ntl-dev
📊 Benchmark resultsComparing with 3412ff2 Package size: 263 MB⬇️ 0.00% decrease vs. 3412ff2
Legend
|
Skn0tt
approved these changes
Feb 20, 2023
*/ | ||
|
||
/** | ||
* @typedef EdgeFunctionDeclarationWithPattern | ||
* @type {object} | ||
* @property {string} function | ||
* @property {string} pattern | ||
* @property {string=} name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about optional parameters in JSDoc types!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saaaaaaameee
…s-when-running-ntl-dev
khendrikse
deleted the
feat-373/show-display-name-for-edge-functions-when-running-ntl-dev
branch
February 20, 2023 13:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://github.com/netlify/pod-compute/issues/373
We really wanna show fancy display names if we have them :) for a more delightful user experience!
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)