fix!: execute user and integrations edge functions in the correct order #5624
Conversation
📊 Benchmark resultsComparing with 9066166 Package size: 302 MB⬆️ 0.00% increase vs. 9066166 |
| const [internalFunctions, userFunctions] = await Promise.all([ | ||
| this.#scanForFunctions(this.#internalDirectories), | ||
| this.#scanForFunctions(this.#directories), | ||
| ]) |
There was a problem hiding this comment.
- We read files separately for internal vs. user
|
|
||
| this.#userFunctionConfigs = this.#userFunctions.reduce( | ||
| // eslint-disable-next-line no-plusplus | ||
| (acc, func) => ({ ...acc, [func.name]: functionsConfig[index++] }), |
There was a problem hiding this comment.
- We create separate functionConfigs for user vs internal
danez
changed the title
No it wasn't strictly necessary, but as I moved things around inside the registry I was never sure if this method/property is public or private. I know it makes the PR a little hard to review. |
Yeah I think in general it makes the code harder to read, which makes me wonder if it is worth the trade-off. |
Summary
This turned out to be a bigger change than anticipated. The main change is splitting up the directories in user and internal, so that we can call
bundler.findfor each of them. We still have to run them together, but the functionConfig returned frombundler.serveis again split up, so that we can generate the correct manifest with the correct order.Soon to be documented:
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)