Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: tests/integration/310.command.dev.exec.test.cjs #5886

Merged
merged 8 commits into from
Jul 28, 2023
Merged

refactor: tests/integration/310.command.dev.exec.test.cjs #5886

merged 8 commits into from
Jul 28, 2023

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Jul 22, 2023 •
edited
Loading

  • replace ava with vitest
  • move and rename test file

🎉 Thanks for submitting a pull request! 🎉

Summary

Convert test file to ESM and replace ava with vitest

Related to #5698

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@hereje
refactor: tests/integration/310.command.dev.exec.test.cjs
1d1b796 
- replace ava with vitest
- move and rename test file
@github-actions
Copy link

github-actions bot commented Jul 22, 2023 •
edited
Loading

📊 Benchmark results

  • Dependency count: 1,303
  • Package size: 271 MB

@lukasholzer
Copy link
Collaborator

@hereje are they ready to review?

@hereje
Copy link
Contributor Author

hereje commented Jul 25, 2023 •
edited
Loading

@hereje are they ready to review?

Yes, I'll change it to Ready for review.

@hereje hereje marked this pull request as ready for review July 25, 2023 14:47
@hereje hereje requested a review from a team as a code owner July 25, 2023 14:47
hereje and others added 4 commits July 26, 2023 23:30
@hereje @lukasholzer
Apply suggestions from code review
b730e8b 
feat: rename environment variable

Co-authored-by: Lukas Holzer <[email protected]>
@hereje @lukasholzer
Apply suggestions from code review
cf6d8bd 
feat: update environment variable

Co-authored-by: Lukas Holzer <[email protected]>
@hereje
Update dev.exec.test.mjs
9f81b60 
feat: update environment variable
@hereje
Merge branch 'main' into refactor_test_esm/tests/integration/310.comm…
82f2fa8 
…and.dev.exec.test.cjs
sarahetter
sarahetter approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@sarahetter sarahetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label Jul 28, 2023
@kodiakhq kodiakhq bot merged commit 3678e31 into netlify:main Jul 28, 2023
63 checks passed
@hereje hereje deleted the refactor_test_esm/tests/integration/310.command.dev.exec.test.cjs branch July 28, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasholzer lukasholzer lukasholzer left review comments

@sarahetter sarahetter sarahetter approved these changes

Assignees
No one assigned
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hereje @lukasholzer @sarahetter