feat: add uncaughtException handler
#6011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with e6f5113
|
|
@netlify/support-pod-engineering would love a thumbs up from you on the copy. |
|
Future want maybe - some way of adding a error ID of some kind for support cases to be tracked against errors automatically reported to the APM |
|
either @hrishikesh-k or @littlemarcus can take a look at this for Support - thank you! |
|
This is so cool!!! Thank you for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
uncaughtExceptionhandler to the process so that we can wrap any uncaught exceptions with some nice messaging explaining that an error with the Netlify CLI itself has occurred. The message also includes useful links and the full system info, ready to be copied and pasted to a bug report.