Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose params to edge functions with cache: "manual" #6194

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

eduardoboucas
Copy link
Member

@eduardoboucas eduardoboucas commented Nov 20, 2023

Summary

When collecting the list of routes to extract parameters from, we were only considering routes and not post_cache_routes. This PR fixes that.

In the process, I've refactored the edge functions registry to use TypeScript. I've done this in a separate commit to make it (a little bit) easier to review.

Closes https://linear.app/netlify/issue/COM-145/cached-edge-function-params-not-set-in-local-dev.

@eduardoboucas eduardoboucas requested a review from a team as a code owner November 20, 2023 10:05
Copy link

📊 Benchmark results

Comparing with a5a3e3a

  • Dependency count: 1,408 ⬆️ 0.85% increase vs. a5a3e3a
  • Package size: 421 MB ⬆️ 4.07% increase vs. a5a3e3a

@eduardoboucas eduardoboucas merged commit f1986d9 into main Nov 20, 2023
35 checks passed
@eduardoboucas eduardoboucas deleted the fix/post-cache-ef-params branch November 20, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants