-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove dependency on copy-template-dir #6659
Merged
Lunnatica
merged 8 commits into
main
from
paulalopezantelo/ct-1055-remove-deprecated-packages-from-cli-that-are-displayed-on
May 24, 2024
Merged
fix: remove dependency on copy-template-dir #6659
Lunnatica
merged 8 commits into
main
from
paulalopezantelo/ct-1055-remove-deprecated-packages-from-cli-that-are-displayed-on
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackages-from-cli-that-are-displayed-on
…ackages-from-cli-that-are-displayed-on
…ackages-from-cli-that-are-displayed-on
TylerBarnes
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dope! 🙌 🚀
Lunnatica
deleted the
paulalopezantelo/ct-1055-remove-deprecated-packages-from-cli-that-are-displayed-on
branch
May 24, 2024 08:38
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #5724
We want to get rid of the deprecation warnings when running
npm i -g netlify-cli
.This was caused by an outdated dependency in
copy-template-dir
,readdirp
.Since the package is no longer being maintained, this PR brings in the functionality of
copy-template-dir
so we can update readdirp to the latest version ourselves. A few changes to thecopy-template-dir
functionality have been done as part of this:graceful-fs
)cb
argumentTesting
Running
npm i
in main (before changes):Running
npm i
in the branch (with the changes):For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)