Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove to-readable-stream #6685

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Conversation

rjbeers
Copy link
Contributor

@rjbeers rjbeers commented Jun 2, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

This should replace #6599.

The dependency was outdated. The latest version recommends using node:streams Readable.from() to produce a nodejs stream.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

The dependency was outdated. The latest version recommends using
`node:streams` `Readable.from()` to produce a nodejs stream.
@rjbeers rjbeers requested a review from a team as a code owner June 2, 2024 02:48
Copy link

github-actions bot commented Jun 2, 2024

📊 Benchmark results

Comparing with 59f8433

  • Dependency count: 1,212 ⬇️ 0.08% decrease vs. 59f8433
  • Package size: 313 MB ⬇️ 0.01% decrease vs. 59f8433
  • Number of ts-expect-error directives: 976 (no change)

@eduardoboucas eduardoboucas changed the title chore(deps): remove to-readable-stream feat: remove to-readable-stream Jun 20, 2024
Copy link
Collaborator

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukasholzer lukasholzer added the automerge Add to Kodiak auto merge queue label Jul 1, 2024
@kodiakhq kodiakhq bot merged commit a265859 into main Jul 1, 2024
48 checks passed
@kodiakhq kodiakhq bot deleted the rjbeers/remove-to-readable-stream branch July 1, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants