fix: apply default origin to plugins provided by plugin detection #6781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Part of https://linear.app/netlify/issue/FRP-1218/plugin-netlifyplugin-nextjs-must-not-be-specified-twice-in-the-app
We are setting
default
origin for build command and publish dir, but not for plugins we set from plugin detection - this makes that all setting provided by plugin detection has correspondingorigin
property set. See netlify/build#5793 on how addedorigin
actually fixes the issueFor us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)