Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply default origin to plugins provided by plugin detection #6781

Merged

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Aug 6, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

Part of https://linear.app/netlify/issue/FRP-1218/plugin-netlifyplugin-nextjs-must-not-be-specified-twice-in-the-app

We are setting default origin for build command and publish dir, but not for plugins we set from plugin detection - this makes that all setting provided by plugin detection has corresponding origin property set. See netlify/build#5793 on how added origin actually fixes the issue


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Copy link

github-actions bot commented Aug 6, 2024

📊 Benchmark results

Comparing with 7751edc

  • Dependency count: 1,222 (no change)
  • Package size: 313 MB ⬇️ 0.00% decrease vs. 7751edc
  • Number of ts-expect-error directives: 977 (no change)

@pieh pieh marked this pull request as ready for review August 19, 2024 13:55
@pieh pieh requested a review from a team as a code owner August 19, 2024 13:55
Copy link
Collaborator

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's a great addition!

@pieh pieh merged commit 4a3eb18 into main Aug 19, 2024
48 checks passed
@pieh pieh deleted the fix/apply-default-origin-to-plugins-added-by-framework-detection branch August 19, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants