Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accountId to build options #6783

Conversation

lemusthelroy
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Adding accountId to build options so that we can make requests to find which extensions are installed on a site


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lemusthelroy lemusthelroy requested a review from a team as a code owner August 8, 2024 11:47
Copy link

github-actions bot commented Aug 8, 2024

📊 Benchmark results

Comparing with 1881e07

  • Dependency count: 1,222 (no change)
  • Package size: 313 MB ⬇️ 0.00% decrease vs. 1881e07
  • Number of ts-expect-error directives: 977 (no change)

@lemusthelroy lemusthelroy merged commit 85dc37f into main Aug 8, 2024
48 checks passed
@lemusthelroy lemusthelroy deleted the lemusthelroy/cpla-1747-jigsaw-exclude-any-v1-installation-for-a-site-build-that branch August 8, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants