Deploy: Force async on large deployments #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaeesBhatti
changed the title
|
Reasoning is explained here: https://netlify.slack.com/archives/C9D3B8RGF/p1593767386073000 |
erezrokah
approved these changes
Jul 5, 2020
kitop
added a commit
to kitop/js-client
that referenced
this pull request
Sep 14, 2020
So we have the same value as CLI: https://github.com/netlify/cli/blob/aa2f348e669a460fed1f6a46068c4457e9b40733/src/commands/deploy.js#L210 See netlify/cli#966 for context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes: #745
- Test plan
Test manually with large scale sites that fail with timeout
- Description for the changelog
Set deployment
syncFileLimit: 1to force an async deployment- A picture of a cute animal (not mandatory but encouraged)
🐠