-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip purgeCache in local dev #472
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraerino
reviewed
Feb 13, 2024
Co-authored-by: Marcus Weiner <[email protected]>
mraerino
approved these changes
Feb 13, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.6.0](v2.5.1...v2.6.0) (2024-02-13) ### Features * publish ESM version ([#473](#473)) ([b1b7553](b1b7553)) ### Bug Fixes * **deps:** update dependency @netlify/serverless-functions-api to v1.13.1 ([#462](#462)) ([29b33ae](29b33ae)) * **deps:** update dependency @netlify/serverless-functions-api to v1.14.0 ([#470](#470)) ([c77eb33](c77eb33)) * skip purgeCache in local dev ([#472](#472)) ([9236053](9236053)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
This was referenced Jun 7, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
Currently running
purgeCache
in local development throws an error. While I wouldn't expect it to actually purge anything (because there's no cache anyway), this prevents us running dev for any site that does use this.Describe the solution you've chosen
Log a message and return if called in local dev without a token. If a token is passed I assume the user knows what they're doing and wants it to work for real.
Describe alternatives you've considered
Example: Another solution would be [...]
Checklist
Please add a
x
inside each checkbox: