chore: fix linting errors #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orinokai
added
type: chore
ascorbic
reviewed
Apr 14, 2022
src/__tests__/gatsby-node.ts
Outdated
| writeFile: jest.fn(), | ||
| } | ||
| }) | ||
| /* eslint-disable import/first, max-nested-callbacks */ |
There was a problem hiding this comment.
Probably best to add a general override, disabling this for all test files, like we've done in the build plugins: https://github.com/netlify/netlify-plugin-gatsby/blob/main/.eslintrc.js#L21
There was a problem hiding this comment.
Ah, thanks. I was trying to do this by adding another .eslintrc file to the test folder, but couldn't figure out a neat way to get Jest to ignore it. This is a much better solution.
| @@ -1,4 +1,4 @@ | |||
| import _ from "lodash" | |||
| import _ from 'lodash' | |||
There was a problem hiding this comment.
One day we should see if we can remove lodash. The gatsby codebase is littered with pointless use of it.
There was a problem hiding this comment.
Good call. I've added a draft ticket to the board.
ascorbic
approved these changes
Apr 14, 2022
sarahetter
pushed a commit
that referenced
this pull request
Apr 19, 2022
* chore: fix linting errors * chore: fix linting errors * chore: add general eslint override for test files * chore: switch fs promises to fs-extra so tests lint correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all lint errors on the repo, potentially introduced by changes to @netlify/eslint-config-node. There are still a number of lint warnings, mainly regarding
type: any, which I will open an internal issue about.