Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve plugins and loaders #137

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Resolve plugins and loaders #137

merged 1 commit into from
Apr 15, 2019

Conversation

alexandernanberg
Copy link
Contributor

@alexandernanberg alexandernanberg commented Apr 12, 2019

In one of my projects I started to get errors saying that babel-loader was not found etc. I could solve this locally by resolving them with require.resolve

Could maybe also fix #66

In one of my projects I started to get errors saying that `babel-loader` was not found etc. I could solve this locally by resolving them with `require.resolve`
@swyxio
Copy link
Contributor

swyxio commented Apr 15, 2019

ohh is that how to fix it? i really dont understand babel configs work sometimes :( i thought you could only pass the name of the plugin

edit: wow: babel/babel-loader#166 (comment)

@swyxio swyxio merged commit 9c78a3f into netlify:master Apr 15, 2019
@CarlosMed
Copy link

CarlosMed commented Apr 15, 2019

Well would you look at that. Here I thought it was a mismatch in babel-loader.

Ill review with a new react app and report back if its fixed.

@swyxio
Copy link
Contributor

swyxio commented Apr 16, 2019

for the record ive never had a problem with the old netlify-lambda using create-react-app-lambda. anyway, i updated it, and retested, and it still works. so as far as i'm concerned theres no regression and maybe a small chance of improvement 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Babel-loader - hidden dependency
3 participants