Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include environment variables from config #22

Merged
merged 2 commits into from
Apr 3, 2018

Conversation

kchung
Copy link
Contributor

@kchung kchung commented Apr 2, 2018

On a production lambada, you can access your netlify.toml environment variables, but in this package the same isn't available during development, this PR adds the variables from the config on the the process.env just like how production works.

  • Include netlify.toml environment variables

@leonardodino
Copy link
Contributor

leonardodino commented Apr 2, 2018

awesome addition! :D

just wish i could access my "private" environment variables, the one not checked into the repo, the ones set on the dashboard, maybe expose all the build process.env to the child process? or some way to configure it? I know the ones on the toml overwrite the dashboard ones..


update: moved to using DefinePlugin on the the custom webpack, config, solves it for me.

@biilmann biilmann merged commit 63a7888 into netlify:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants