Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'queryStringParameters' when the url contains multiple question marks #85

Merged
merged 1 commit into from
Dec 15, 2018
Merged

Fix 'queryStringParameters' when the url contains multiple question marks #85

merged 1 commit into from
Dec 15, 2018

Conversation

marcomontalbano
Copy link
Contributor

@marcomontalbano marcomontalbano commented Dec 14, 2018

This fix is related to the issue #54.

Given a request that looks something like this:

?url=https://www.youtube.com/watch?v=0uwe_PhCRcY&filter[0][field]=title&filter[0][value]=TestElement

The value of event.queryStringParameters should be an object like this:

{
    "url" : "https://www.youtube.com/watch?v=0uwe_PhCRcY",
    "filter[0][field]" : "title",
    "filter[0][value]" : "TestElement"
}

Instead of the following object:

{
    "url": "https://m.youtube.com/watch"
}

@swyxio
Copy link
Contributor

swyxio commented Dec 15, 2018

i see. fair enough.

@swyxio swyxio merged commit 1d541c9 into netlify:master Dec 15, 2018
@swyxio
Copy link
Contributor

swyxio commented Dec 15, 2018

v1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants