This repository has been archived by the owner on May 10, 2021. It is now read-only.
revert route/redirect sorting logic to static then dynamic #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinnWoelm
reviewed
Jan 17, 2021
FinnWoelm
reviewed
Jan 17, 2021
FinnWoelm
reviewed
Jan 17, 2021
FinnWoelm
reviewed
Jan 17, 2021
FinnWoelm
reviewed
Jan 17, 2021
|
If anyone stumbles upon this, Node.js changed the argument order in .sort() from version 10 to version: nodejs/node#24294 This was intentional, to stabilize the sort order, so that the array wouldn't change at all, if the compareFunction in sort() always returned 0. However, this causes issues with our tests, of course, where some are using the old argument order and some the new one. We will have to make sure that our sorts always return a positive or negative value, and not a 0, I guess 😊 |
lindsaylevine
force-pushed
the
ll/revert-sorting-logic
branch
from
e9172ad
to
f83cb31
Compare
lindsaylevine
added a commit
that referenced
this pull request
Jan 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this one absolutely needs to be reviewed by finn. the old logic to which we're reverting did not seem to sort static routes, but i think we can sort them as well? separately from the dynamic ones obv - i'm not too sure why we wouldn't.
Fixes #76