This repository has been archived by the owner on May 10, 2021. It is now read-only.
add check if pages-manifest exists before reading #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
reviewed
Jan 18, 2021
| join(NEXT_DIST_DIR, "serverless", "pages-manifest.json") | ||
| ); | ||
| const manifestPath = join(NEXT_DIST_DIR, "serverless", "pages-manifest.json"); | ||
| if (!existsSync(manifestPath)) return {}; |
There was a problem hiding this comment.
Just to make sure: would next-on-netlify still behave correctly even if this function returns an empty object?
There was a problem hiding this comment.
yes! each place that uses getPagesManifest iterates over it using Object.entries
so it'd be calling Object.entries({}) which returns an empty array meaning no pages will get included (as appropriate, if there's somehow no pages-manifest) for the relevant page types
ehmicky
approved these changes
Jan 19, 2021
lindsaylevine
added a commit
that referenced
this pull request
Jan 26, 2021
- Put back next/image support ([#158](#158)) - Fix: strip file extension when checking if route is dynamic ([#155](#155)) - Fix: prevent copy of .public to .public ([#146](#146)) - Fix: add check if pages-manifest exists before reading ([#147](#147)) - Fix: throw error if .next/static cannot be found ([#148](#148)) - Fix: remove unnecessary * from headers rule ([#152](#152))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136