This repository has been archived by the owner on May 10, 2021. It is now read-only.
Fixed redirect for index with getServerSideProps #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinnWoelm
added a commit
that referenced
this pull request
Sep 13, 2020
Add test to ensure that a NextJS app with an index.js page with getServerSideProps sets up the correct rewrite for the data route. See: #39
FinnWoelm
added a commit
that referenced
this pull request
Sep 13, 2020
Fix rewrite for data route when pages/index.js uses getServerSideProps. See: #39 Thanks, @jonasbuntinx 🙌
FinnWoelm
added a commit
that referenced
this pull request
Sep 13, 2020
Thank you, @jonasbuntinx! 🙌😊
|
Thank you, @jonasbuntinx! Great catch and thank you for the fix 🔥 Much appreciated! PS: If you are building something awesome with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding
getServerSidePropstoindex.js,next-on-netlifywould addto the
out_publish/_redirectsfile.I added a fix so that
will be written instead.