This repository has been archived by the owner on May 10, 2021. It is now read-only.
Copy host property from headers to multiValueHeaders #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is perfect, @leomeneguzzi! 🙌 We will merge this as soon as possible! |
|
@FinnWoelm It looks like the PR is missing a label and that caused the tests to fail. Can you look into this? |
|
@s-kris @leomeneguzzi i'll get this taken care of asap! |
|
@lindsaylevine could we merge this and publish it? It is very crucial to us. |
cassidoo
approved these changes
Oct 1, 2020
|
closing because of conflict in favor of #44 and getting out asap |
|
@s-kris @leomeneguzzi @abdelhamid-attaby this was just published! |
|
Thanks @lindsaylevine but I opened a same issue with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone, looking for a solution to to resolve #40 I did my fork, and case this is acceptable in the project, I will let my PR 😄
This PR takes the host property from
event.headersand copy to host inevent.multiValueHeaders.I'm opening this PR just in case you think this a good way to solve this problem.
PS: If you think that has another way, just give the suggest and I will take a look and implement.
PS: I don't know if this change specifically needs some test, if need, what exactly I can test.