This repository has been archived by the owner on May 10, 2021. It is now read-only.
Catch-all routes (reopening of PR#1) #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new version of serverless-nextjs-component has been released. It introduces support for dynamic catch-all routes. Integrating these changes means that we can also support dynamic catch-all routes.
Create an adaptation of serverless-next.js' expressifyDynamicRoute function: getNetlifyRoute. Our getNetlifyRoute function differs from the expressifyDynamicRoute in that it converts catch-all routes from [...params] to /:* rather than to /:params*. The latter does not work with Netlify routing, but our version does.
Closed
Acknowledge their help with adding support for catch-all routes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is re-opening the pull request proposed by @spencewood. I accidentally messed up their pull request #1 🙈 I'll keep my fingers off force pushing from now on...