fix: add next.js 12's new /trace endpoint to HIDDEN_PATHS #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The location of the `trace` file changed in vercel/next.js#28728.
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👷 Deploy request for netlify-plugin-nextjs-static-root-demo pending review.Visit the deploys page to approve it
|
👷 Deploy request for netlify-plugin-nextjs-export-demo pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
oof, a whole lot of errors in the checks. please let me know if you have any hints on how to get those to pass! |
ascorbic
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The location of the
tracefile generated by next.js's build changed from/traces/traceto/tracein next.js v12 (from this PR in particular).Currently, going to
/traceon a nextjs v12 + netlify site serves thetracefile like any other static file. This PR prevents that in the same way it also prevents access to/traces.Test plan
/tracepage https://deploy-preview-1259--netlify-plugin-nextjs-demo.netlify.app/trace/tracespage https://deploy-preview-1259--netlify-plugin-nextjs-demo.netlify.app/tracesRelevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
vercel/next.js#28728
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.