NETOBSERV-1831: disambiguate overlapping IPs from MAC

[jotak]

Description

This is an alternative, best-effort solution when there are overlapping IPs and we cannot index by MAC due to lack of consistency of the observed MAC (because cross-node traffic might show node's MAC instead of Pod's MAC). Using MAC as index cannot work in this situation, however, we can still use solely IPs for indexing, which might result in having a shortlist of pods after cache lookup in case of overlapping IPs: the best-effort solution here is to then select by MAC from that shortlist.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci-robot]

@jotak: This pull request references NETOBSERV-1831 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Description

This is an alternative, best-effort solution when there are overlapping IPs and we cannot index by MAC due to lack of consistency of the observed MAC (because cross-node traffic might show node's MAC instead of Pod's MAC). Using MAC as index cannot work in this situation, however, we can still use solely IPs for indexing, which might result in having a shortlist of pods after cache lookup in case of overlapping IPs: the best-effort solution here is to then select by MAC from that shortlist.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 31.81818% with 45 lines in your changes missing coverage. Please review.

Project coverage is 65.12%. Comparing base (bc3d4eb) to head (2d16716).

Files with missing lines	Patch %	Lines
...peline/transform/kubernetes/informers/informers.go	33.96%	35 Missing ⚠️
pkg/pipeline/transform/kubernetes/cni/multus.go	0.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   65.47%   65.12%   -0.35%     
==========================================
  Files         108      108              
  Lines        7026     7066      +40     
==========================================
+ Hits         4600     4602       +2     
- Misses       2108     2148      +40     
+ Partials      318      316       -2     

Flag	Coverage Δ
unittests	65.12% <31.81%> (-0.35%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/pipeline/transform/kubernetes/enrich.go	79.34% <100.00%> (+0.22%)	⬆️
...e/transform/kubernetes/informers/informers-mock.go	97.19% <100.00%> (ø)
pkg/pipeline/transform/kubernetes/cni/multus.go	61.11% <0.00%> (-9.86%)	⬇️
...peline/transform/kubernetes/informers/informers.go	20.20% <33.96%> (-1.89%)	⬇️

[memodi]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/flowlogs-pipeline:f49aaec

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=f49aaec make set-flp-image

[jotak]

/hold
I thought this PR could help for both UDN (later) and the multus/secondary interfaces enrichment but it actually doesn't, because only primary network IPs are indexed. It may still be useful for UDN later though (we'll see in 1.8) - but no need to merge for 1.7