Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface IRouteMeta define API for RoutingPanel. #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Interface IRouteMeta define API for RoutingPanel. #114

wants to merge 1 commit into from

Conversation

h4kuna
Copy link

@h4kuna h4kuna commented Feb 1, 2016

Issue #113

* Return route mask.
* @return string
*/
public function getMask();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nette doesn't use visibility in interfaces.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fixed.

@Majkl578
Copy link
Contributor

Majkl578 commented Feb 1, 2016

I don't like the name, it sounds like an abbreviation. :/

@h4kuna
Copy link
Author

h4kuna commented Feb 1, 2016

@Majkl578 What do you suggest?

I named in issue as IRouteBar. What do you think about IRouteInfo, IRouteMask, IRouteMaskBar, IRoutingPanelRoute?

@JanTvrdik
Copy link
Contributor

Generally good idea but the issue is much more complex.

@dg dg force-pushed the master branch 2 times, most recently from 20a93ca to 08cbdeb Compare February 8, 2016 13:39
@h4kuna
Copy link
Author

h4kuna commented Feb 9, 2016

@JanTvrdik Let's describe it.

@JanTvrdik
Copy link
Contributor

You need to consider custom routers (which can do pretty much anything) as well. Some custom routers may be just wrappers of another routers, some do complex logic.

The entire interface of routing bar may need to be redesigned to be able to clearly display advanced router configurations. For start it needs to support tree of routers, not a list.

@foxycode
Copy link
Contributor

@JanTvrdik You are true, but I think this is good step forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants