Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added RejectedRequestException #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added RejectedRequestException #173

wants to merge 1 commit into from

Conversation

dg
Copy link
Member

@dg dg commented Jan 26, 2017

In case that framework rejects request, it throws RejectedRequestException instead of BadRequestException or BadSignalException. The BadSignalException should be deprecated in future.

The main reason is to reach finer granularity for BadRequestException exception.

The naming should be discussed. Is better RejectRequestException or RejectedRequestException? What about constants in RejectedRequestException?

ping @JanTvrdik @matej21

dg referenced this pull request Jan 26, 2017
…stead BadRequestException when incompatible type is object
@dg dg force-pushed the v2.4 branch 2 times, most recently from 30b8609 to 97edb43 Compare January 26, 2017 17:18
@dg dg force-pushed the reject branch 2 times, most recently from dedb5e5 to 4e07a2d Compare January 27, 2017 01:39
@dg dg changed the base branch from v2.4 to master January 27, 2017 01:40
@dg dg force-pushed the master branch 2 times, most recently from 88ef0bd to b7df270 Compare February 2, 2017 02:44
@dg dg force-pushed the master branch 10 times, most recently from 8dabc1a to 2e29386 Compare July 12, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant