Make Presenter::createRequest non-final #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
force-pushed
the
master
branch
2 times, most recently
from
ef333e6
to
9d529b4
Compare
|
bump |
… object properties
…according to naming convention
…m creation of the Template
Automatically will register methods as latte custom functions
dg
force-pushed
the
master
branch
2 times, most recently
from
806cba6
to
2c9e9d2
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
ea5ac15
to
0e37ebd
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
af99b74
to
ad60129
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
cfac883
to
45d9ace
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
3fb89c6
to
fcb2578
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
3c5786c
to
f84c16a
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
13f5ab3
to
c15bd94
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
b3dcfb1
to
de09883
Compare
dg
added a commit
that referenced
this pull request
Feb 5, 2021
dg
added a commit
that referenced
this pull request
Feb 5, 2021
|
Finally, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
Presenter::createRequest()method non-final.Furthermore, inside
Presenter::createRequest()callstatic::argsToParams()instead ofself::argsToParams()to allow for extension.Rationale
The rationale behind the change is simple: allow for extension of link creation.
For well over 6 years, since
2.0.14, it has been non-final, and now it is final in3.0again. It was final in2.0.*, then made non-final in2.0.14just half a year later. It was final in0.*versions, but those were deep medieval ages.Use cases
I now have two use cases that require the method's extension.
action*method's arguments being passed.Thank you for considering this.