Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getReferer method missing in IRequest #137

Closed
misaon opened this issue Mar 22, 2018 · 3 comments
Closed

getReferer method missing in IRequest #137

misaon opened this issue Mar 22, 2018 · 3 comments

Comments

@misaon
Copy link
Contributor

misaon commented Mar 22, 2018

  • bug report? yes
  • feature request? no
  • version: 2.4.7

Hi, when i write $this->getHttpRequest()->getReferer() i encountered a problem when the IDE PhpStorm did not know about the getReferer() method. The reason is that the method is missing in IRequest. I want to ask if it is deliberate or a bug. It would be good either to add or add an appropriate annotation to the IDE to understand that the getReferer method is accessible.
...

snimek obrazovky 2018-03-22 v 12 44 39

@dg
Copy link
Member

dg commented Mar 22, 2018

It is possible that there are more missing methods. But bad is that adding them to the interface is a big BC break…

@misaon
Copy link
Contributor Author

misaon commented Mar 23, 2018

@dg How about adding @method Url|null getReferer() Returns referrer. annotation to head of the interface like this? I tried and works great. Additionally, it does not create an BC break.

snimek obrazovky 2018-03-23 v 9 38 28

@dg
Copy link
Member

dg commented Mar 26, 2018

It seems like solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants